Skip to content

Minor fixes to subgroupBroadcast tests - #4721

Merged
sudonatalie merged 1 commit into
gpuweb:mainfrom
sudonatalie:subgroup-broadcast-checker-fixes
Oct 24, 2026
Merged

sudonatalie merged 1 commit into
gpuweb:mainfrom
sudonatalie:subgroup-broadcast-checker-fixes

Conversation

@sudonatalie

Copy link
Copy Markdown
Contributor

Fix subgroupBroadcast fragment checker copy paste errors:

  • Exclude the last column using the framebuffer width rather than its height.
  • Compare each subgroup's size against the number of invocations seen rather than against itself. Skip groups whose broadcasting invocation was not found, since their results are indeterminate.

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

Fix subgroupBroadcast fragment checker bounds and size check:
- Exclude the last column using the framebuffer width rather than its
  height (copy paste error).
- Compare each subgroup's size against the number of invocations seen
  rather than against itself. Skip groups whose broadcasting invocation
  was not found, since their results are indeterminate.
@github-actions

Copy link
Copy Markdown

Results for build job (at f21a22f):

 Test case/subcase counts did not change.

@sudonatalie
sudonatalie merged commit d116bcc into gpuweb:main Oct 24, 2026
1 check passed
@sudonatalie
sudonatalie deleted the subgroup-broadcast-checker-fixes branch October 24, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants