Repository navigation
fix(grpc-js): stop retry attempts after the call is cancelled - #3117
Merged
murgatroid99 merged 1 commit intoOct 28, 2026
Merged
murgatroid99 merged 1 commit into
murgatroid99 merged 1 commit into
Conversation
cancelWithStatus() reported the status and cancelled the child calls, but left the retry state unchanged and the backoff timer running. When a call was cancelled while a retry was waiting out its backoff, the timer still started a new attempt, and the call kept retrying through its remaining attempts after the application had cancelled it. Those attempts are sent after reportStatus() has cleared the write buffer, so a unary attempt carries headers but no message. The server never responds, and the stream stays open until the connection closes, occupying one of the server's concurrent streams. Enough of them block every new call on the channel. Track the retry timer, and on cancellation disable further attempts and clear the retry and hedging timers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #3102 to 1.14.x