Skip to content

grpc-js: use default service config on invalid first resolution - #3132

Open
obaseyi2 wants to merge 1 commit into
grpc:masterfrom
obaseyi2:fix/grpc-js-default-service-config-fallback
Open

obaseyi2 wants to merge 1 commit into
grpc:masterfrom
obaseyi2:fix/grpc-js-default-service-config-fallback

Conversation

@obaseyi2

Copy link
Copy Markdown

When a resolver's first result contains an invalid service config, grpc-js currently rejects the result even if the channel explicitly provided grpc.service_config. Use that configured default in this case, as specified by gRFC A21, while retaining the resolution failure when no default was provided.

Add regression tests for both outcomes with a resolver that returns valid addresses and an invalid service config.

Fixes #3121

@linux-foundation-easycla

linux-foundation-easycla Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: obaseyi2 / name: obaseyi2 (ccd6e7f)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grpc-js: default service config (grpc.service_config) is not used when the first resolver result has an invalid service config

1 participant