Skip to content

Fixed negative progress when using a preprocessor - #83

Open
jessevz wants to merge 2 commits into
masterfrom
fix-negative-progress
Open

jessevz wants to merge 2 commits into
masterfrom
fix-negative-progress

Conversation

@jessevz

@jessevz jessevz commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

fixes python agent for hashtopolis/server#2634

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Piped rule expansion can make CURKU reach the chunk-end checkpoint before all base words are processed, potentially skipping untested work after an interruption.

1 open issue
What changed in this PR

This PR addresses negative progress reporting in the Python agent for preprocessor and other piped hashcat runs, targeting server issue #2634.

Changes:

  • Adds a checkpoint helper that applies the chunk offset to piped progress and clamps it to the chunk end.
  • Captures piping mode before status processing and uses the helper in progress reports.
  • Adds unit tests for direct runs, piped offsets, zero restore points, and clamping.
File Description
tests/​test_keyspace_progress.py Adds checkpoint calculation tests.
htpclient/​hashcat_cracker.py Adds and integrates piped checkpoint adjustment.

Review effort: Balanced

Comment thread htpclient/hashcat_cracker.py Resolved
@jessevz
jessevz requested a balanced review from Copilot November 18, 2026 13:20
@jessevz
jessevz marked this pull request as ready for review November 18, 2026 13:20
@jessevz
jessevz requested a review from s3inlc November 18, 2026 13:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@jessevz
jessevz requested a balanced review from Copilot November 19, 2026 08:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants