[jooola]

Adds a new hcloud server screenshot -o screenshot.png <server>, that take a screenshot of the server console using a VNC client.

Fixes #1420

[jooola]

Still missing from this PR:

• Finalize the e2e test.
• Replace slog logger with what the CLI is using.
• Hide log messages from the go-vnc library.
• Check if another fork og go-vnc is better that the one from alexnet, I saw other forks being a bit more active.
• Maybe golang.org/x/net/websocket is not the best library, but it does not add a new dependency. Check if this is important.

[codecov]

Codecov Report

❌ Patch coverage is 71.21212% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.61%. Comparing base (c9b04e2) to head (3af1171).

Files with missing lines	Patch %	Lines
internal/cmd/server/screenshot.go	58.58%	41 Missing ⚠️
internal/cmd/util/vncutil/screenshot.go	82.35%	15 Missing ⚠️
internal/cli/root.go	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
+ Coverage   75.48%   79.61%   +4.13%     
==========================================
  Files         303      305       +2     
  Lines        9593     9787     +194     
==========================================
+ Hits         7241     7792     +551     
+ Misses       2352     1995     -357     

Flag	Coverage Δ
e2e	55.14% <69.19%> (?)
unit	74.22% <12.62%> (-1.27%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[apricote]

Would be awesome if users could directly show it in their terminal.

For example with the Kitty graphics protocol I can run this right now to render the image in the terminal (Ghostty):

hcloud server screenshot <name>
viu screenshot.png

If -o - would mean stdout:

hcloud server screenshot <name> -o - | viu -

[jooola]

Looks good, maybe we could improve the maintainability of this new code.

Please rebase on top of the main branch.

[jooola]

Suggested change

	func OpenVNCSession(ctx context.Context, wsURL string, debugOut io.Writer) (*VNCSession, error) {
	func NewVNCSession(ctx context.Context, wsURL string, debugOut io.Writer) (*VNCSession, error) {

[jooola]

Great, thanks for pushing this the extra mile!

Looks good, free to address my suggestion or merge directly.