Skip to content

refactor(base): add useoverride and reference client - #1529

Merged
jooola merged 1 commit into
hetznercloud:mainfrom
wneessen:base-changes
Nov 5, 2026
Merged

jooola merged 1 commit into
hetznercloud:mainfrom
wneessen:base-changes

Conversation

@wneessen

@wneessen wneessen commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
  • Add a UseOverride type to the ListCmd struct to allow to override the default "list" use.
  • Reference the Client in AdditionalFlags so additional flag functions can make use of it.

@wneessen
wneessen requested a review from a team as a code owner November 3, 2026 14:00
@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.47%. Comparing base (c9b04e2) to head (c22e3d8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/base/list.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
- Coverage   75.48%   75.47%   -0.01%     
==========================================
  Files         303      303              
  Lines        9593     9596       +3     
==========================================
+ Hits         7241     7243       +2     
- Misses       2352     2353       +1     
Flag Coverage Δ
unit 75.47% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07 phm07 changed the title feat(base): add useoverride and reference client refactor(base): add useoverride and reference client Nov 5, 2026
- Add a `UseOverride` type to the ListCmd struct to allow
  to override the default "list" use.
- Reference the `Client` in `AdditionalFlags` so additional
  flag functions can make use of it.
@jooola
jooola merged commit fe13b8d into hetznercloud:main Nov 5, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants