Repository navigation
fix(core): a script's hidden clip stays hidden after a jump or a re-entry - #6355
Conversation
186d7ff to
fd611d0
Compare
There was a problem hiding this comment.
Verdict: REQUEST CHANGES · 1 blocker · 0 important · 0 nits · head fd611d0a
The new put-back check stops re-hiding an ended clip when a tween wrote anything other than visible. With autoAlpha that value is inherit, so on a preview jump the clip shows outside its window. Details and a one-word fix ↓ inline.
Scope
Read the full diff on top of #6351 1a42c256 (it is stacked on the head I approved). Read styleHiddenClipsVisibleOnce and the first-render reveal in seekRootChildrenAndAdapters. Ran jsdom probes using the PR's browser-semantics shim, on this head and on 1a42c256. With the suggested change, the PR's 10 tests and my probe all pass. The regression, preview-regression and perf runs are green. No CI workflow ran on this head, which is expected since the base isn't main, so typecheck and unit tests run once the PR retargets.
Edit accuracy: accurate 271 (base branch 271), smooth 147 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (2)
|
fd611d0 to
cb7c9eb
Compare
There was a problem hiding this comment.
Verdict: APPROVE — 1 resolved, 0 open, 0 new · fd611d0a → cb7c9ebe. The rebase on main is clean (range-diff shows the first commit unchanged). All Actions runs are green on this head, including CI. src/runtime: 102 files / 2,484 tests pass locally.
Stacked on #6351, which makes a
tl.set(clip, { visibility: 'hidden' }, t)hide a timed clip. Two cases it left open:data-startstraight past the set (a render chunk that starts mid-timeline, or a scrub) left the clip visible. Before a tween first renders, the runtime shows the clips it will draw so the tween reads their authored style; putting the clips back hid them again with the value they had before, over what the tween had just written. It now leaves a clip alone when the tween changed it.hidden. The runtime now keeps the value the script left and gives it back on re-entry.Checked in a browser on both the preview seek and the render seek: a first seek past the set, 0.5 s then 3 s then 1.5 s, and 2 s then 4.5 s then 3 s all show the expected clips. New runtime tests cover these on both paths, run against browser-style assignment semantics, and fail on #6351's head. The 102 runtime test files pass. The regression shards on this PR are the full check of the producer fixtures.
Regression shards: 10/10 green at the head, no fixture output differs from its baseline.