Repository navigation
fix(cli): audio accepts several files, as its help says - #6535
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Contributor
Edit accuracy: accurate 271 (base branch 271), smooth 168 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (2)
|
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head 1ce21abe
audio already reads every positional from args._. The single-file modes still refuse more than one file: --place-at and --read keep their "exactly one file" errors, and mixing files with a film query still errors. The new guard test fails with the allowlist entry removed. Targeted tests pass locally, and CI and Windows render are green.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why under 100 lines
One entry in an allowlist, its test, and a docs example.
What
hyperframes audio --helplists[FILES]and the command analyzes every file it is given, but a second file was rejected with "Unexpected extra argument": the CLI's central guard against stray positionals (reject-extra-positionals.ts) rejects anything past the declared positional unless the command is on its allowlist, andaudiowas not on it.audiois now on the allowlist, sohyperframes audio a.wav b.wavreturns one report with an item per file.--place-atand--readkeep their existing "exactly one file" errors.Tests
reject-extra-positionals.test.ts:audiowith two files passes the guard (it throws without the allowlist entry); a command that reads one file still gets the extra-argument error.cli.commands.test.ts:audiois checked as a real command in the allowlist.Docs: a several-files example in
docs/packages/cli.mdx.