Skip to content

fix(cli): audio accepts several files, as its help says - #6535

Merged
miguel-heygen merged 1 commit into
mainfrom
fix/cli-audio-several-files
Oct 27, 2026
Merged

miguel-heygen merged 1 commit into
mainfrom
fix/cli-audio-several-files

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

Why under 100 lines

One entry in an allowlist, its test, and a docs example.

What

hyperframes audio --help lists [FILES] and the command analyzes every file it is given, but a second file was rejected with "Unexpected extra argument": the CLI's central guard against stray positionals (reject-extra-positionals.ts) rejects anything past the declared positional unless the command is on its allowlist, and audio was not on it.

audio is now on the allowlist, so hyperframes audio a.wav b.wav returns one report with an item per file. --place-at and --read keep their existing "exactly one file" errors.

Tests

  • reject-extra-positionals.test.ts: audio with two files passes the guard (it throws without the allowlist entry); a command that reads one file still gets the extra-argument error.
  • cli.commands.test.ts: audio is checked as a real command in the allowlist.

Docs: a several-files example in docs/packages/cli.mdx.

@mintlify

mintlify Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
hyperframes 🟢 Ready View Preview Oct 27, 2026, 8:45 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@github-actions

Copy link
Copy Markdown
Contributor

Edit accuracy: accurate 271 (base branch 271), smooth 168 of those

The gate passes.
Smoothness is reported in the artifact, not gated. A case fails only if it fails 2 of 3 runs.

Quarantined, measured but not gated (0)

Unstable (2)

  • seqplainkeys-none-center-r0-root-z100: tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo false, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true
  • seqplainkeys-none-px-r0-root-z100: tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo false, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head 1ce21abe

audio already reads every positional from args._. The single-file modes still refuse more than one file: --place-at and --read keep their "exactly one file" errors, and mixing files with a film query still errors. The new guard test fails with the allowlist entry removed. Targeted tests pass locally, and CI and Windows render are green.

@miguel-heygen
miguel-heygen added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit eba78b4 Oct 27, 2026
72 checks passed
@miguel-heygen
miguel-heygen deleted the fix/cli-audio-several-files branch October 27, 2026 09:27

This branch was successfully deployed

1 active deployment
staging - docs — 1ce21abe Deployed Oct 27, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant