Repository navigation
fix(cli): beats given a media file points to hyperframes audio instead of a folder error - #6544
Conversation
…d of a folder error
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: REQUEST CHANGES · 1 blocker · 0 important · 1 nit · head 880af686
The CLI change itself is fine. The pointer prints and exits 1, the suggested hyperframes audio <file> --only beats --json is a real command, and beats.test.ts passes 21/21 locally. The one blocker is that the CI job fails Skills: manifest in sync. ↓
— genesis-v2
jrusso1020
left a comment
jrusso1020
left a comment
There was a problem hiding this comment.
We rechecked both notes at 4f0af63. The skills manifest is in sync, composition files point to their folder, and media paths with spaces are quoted. All 22 beats tests and an extra spaced-path control pass. The suggested audio command and flags exist; no remaining code blocker found.
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits — 2 resolved, 0 open, 0 new · 880af686 → 4f0af631
The manifest is back in sync (gen:skills-manifest --check ✓). Composition files now point to their folder, paths are quoted, beats tests pass 22/22 locally, and every workflow on this head is green.
What
hyperframes beats <file>now says what to run instead of failing with a bare folder error: it points tohyperframes audio <file> --only beats --json, which analyses one audio or video file. The docs page and the beats skill reference say the same, and the--helpexamples list the audio command.Why
beatstakes a project folder ([dir]): it reads the project's music track and writes the beat file Studio loads. A user who passed it a media file got "Not a directory", which did not tell them the file case exists under a different command.Not changed
beatsstays folder-only. A file mode would need a decision on where the beat file goes and what--jsonprints, andhyperframes audioalready answers that case.Test
A new case in
beats.test.tspasses a project's audio file and expects exit 1 with thehyperframes audio <file> --only beats --jsonpointer; it fails with the check removed. The file's 21 tests passed 3 runs in a row.