Repository navigation
Version 1.3.48 - #805
Merged
Merged
Version 1.3.48#805
Conversation
… are URL fields (#799) Safari saved a transcribe key as a login for the page, with the media URL beside it as the username: the key fields are password inputs, so each tab's form read as a login form and the nearest text field as the username. The five transcribe forms and the three key fields now say they are not for autofill. Every media URL field, on the transcribe tabs and in the import dialogs, is a URL field with the URL autofill hint, so a browser that fills it fills it with addresses. The tabs start through labels that close the dialog, not submit buttons, so the browser's own URL validation is never consulted and an address without a scheme starts as before. The spec asserts that along with the hints on every field and form. The Ionosphere sign-in keeps its login hints: it is a real login. First change after 1.3.47: version 1.3.48, release date cleared. Fixes #799
The tabs start through labels, not submit buttons, so a form whose only text field is the URL field (Whisper, Parakeet) submitted natively on Enter and reloaded the page, dialog and address gone. A delegated submit listener in editor-core cancels the native submission of any form that holds a start control marked data-transcribe-submit, and clicks that control when it is enabled, so Enter runs the path the TRANSCRIBE label runs. A disabled control means Enter does nothing. A host's own dialog gets the same rule by carrying the marker, and a host's real submit button is not clicked a second time. The five transcribe forms carry novalidate, so the URL type from #799 never shows a validation bubble for an address without a scheme. Fixes #802
…t word, and takes a host's lead (#800) Approaching a cut while playing, the skip now seeks as soon as currentTime comes within the lead of it, unmuted, so the sound jumps at the cut itself. The lead covers the player's lag behind its sound plus the seek: 0.27 s in WebKit by ear in a WKWebView, none in Chromium or Firefox, which report true time. A host whose lag or seek time differs sets its own in seconds on window.hyperaudioSkipLead, read on every check and documented beside the declared-schemes hook. The lead is for playback only, so a click on the last word before a cut while paused never jumps past it, and a kept section shorter than two leads waits for the cut rather than lose its words. Inside a cut, after a click or drag into it or with no lead, the skip mutes for its seek as 1.3.47 did, with the unmute tied to that seek. Every skip lands 30 ms before the next kept word rather than 50 ms after it, since word start times sit on an engine's frame grid and the sound often begins ahead of them (#801). Every band a skip covers ends at its landing point, so a landing never skips again, and a cut too short to hold the margin lands on the word start. The leading gap takes the same rule. Re-measured with the tone ladder in Safari 26: currentTime trails the sound by about 0.11 s, the same as a WKWebView, where headless WebKit reads 0.27 s. 1.3.47's figure came from headless WebKit. Safari seeks in 48 ms over http, a WKWebView in 80–200 ms over a custom scheme, which is why one constant cannot suit every host. The spec records the skip's seeks as they are issued, through the element's currentTime setter, since a seeking event can belong to an earlier seek. Fixes #800
…800) Pause, click the last word before a struck stretch (#797), press play: the playhead sat inside the lead band when play began, so the early seek fired on the first check, the rest of that word was never heard and the playhead visibly jumped. The same for a double-click to play on that word, or a drag of the playbar that lands in the band while playing. A check that finds the playhead in a kept section ahead of its band arms that section, and a seek that is not the skip's own disarms. The early seek now needs the section armed, so a playhead that arrived in the band by a seek, or sat there when play began, waits for the cut and mutes for the seek as before. Playing through from before the band is unchanged.
… the length pill reads tenths and single words (#803) A small bar appears centred above a selection in the transcript once the mouse is released, or below it on touch and when there is no room above. Strike out clicks the toolbar's strike button, so captions, history and playback skipping follow as from there, and reads Unstrike when every selected word is struck. Export opens the export dialog with Selection chosen, one word included. A selection made by a double-click, which selects its word as a side effect of playing as often as by choice, gets Strike out only. A read-only transcript gets Export only. The bar goes with the selection, on Escape, on an edit, and never shows behind an open dialog. It takes the corner pill's tint with a primary edge and a shadow. A mousedown on the bar keeps focus and the selection where they are. It is one module, js/selection-menu.js, and removing it removes the bar. The corner pill (#775) stays as it was, and now shows for a single word too and reads to a tenth of a second, so it can be used to check a word's timing. It measures the selected words themselves, without the tenth of a second of padding the exported clip adds at each end, so the Export dialog's whole-second Selection line can differ from it on a short selection. Fixes #803
… nothing (#804) The transcript showed playback progress by text colour only, so once paused the current word was hard to find and a selection over it hid it. The word the player is on now has a 2 px underline in the primary colour, while playing and where play resumes once paused, after a click (#797), a seek or a skip. It is drawn as a background line rather than text-decoration, because a struck word's line-through is an inline style that would override an underline, and a background line sits below a spelling checker's squiggle. Saves and downloads strip the class. With the double-click-to-play setting on, a double-click on a word plays from it and selects nothing: the second press's default is cancelled, so the double-click still reaches the player but no selection is made, no selection bar appears and the word is not hidden under the selection colour. The underline marks it instead. With the setting off a double-click selects its word as before. Fixes #804
… and the menu is cached for offline use (#803, #804) "Underline the current word" on the Playback tab, and "Show a floating menu for selected words" on the Application tab, both on by default. The underline hangs off a class on the root that settings.js sets in the head, so a page with it off never shows it for a frame. The menu reads its setting each time it would show, and the corner pill is unaffected. js/selection-menu.js was missing from the service worker's precache list, so the editor would have loaded without the menu offline. The unit test that every same-origin script is precached caught it. Fixes #803, fixes #804
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.3.48. Fixes #800, fixes #803, fixes #804, fixes #799, fixes #802.
Changed
window.hyperaudioSkipLead. (A strike skip's lead depends on the host's audio lag and seek time, so one constant can't suit every host #800)