Skip to content

lua: use shared sort and IN helpers in remaining list endpoints - #93

Merged
Kzoeps merged 2 commits into
mainfrom
lua/list-helpers-batch3
Nov 18, 2026
Merged

Kzoeps merged 2 commits into
mainfrom
lua/list-helpers-batch3

Conversation

@Kzoeps

@Kzoeps Kzoeps commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Stacked on #92.

Problem

The remaining list endpoints still had inline created_at sort SQL and local IN (...) wrappers.

Fix

  • listBadgeDefinitions, searchBadgeDefinitions, listBadgeAwards, listBadgeResponses, listEvmLinks, listLocations and the actor-follow queries use created_at_sort.
  • listFeatures, profileList and organizationList use add_in; the local wrappers are removed.
  • No behaviour change: the SQL golden from tests: add list endpoint SQL golden safety net #90 is unchanged.
  • Left as is: these endpoints' cursor decoders (different or no length cap), and IN loops that join with ",", since switching them would change SQL text.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
api-endpoints Skipped Skipped Nov 18, 2026 3:54pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0f123c12-a465-4c59-8c28-25222d8818da
Commits

Reviewing files that changed from the base of the PR and between 23c4fed and 35cd6de.

Files selected for processing: 37

  • happyview-modules/lua/endpoints/getFollow.lua
  • happyview-modules/lua/endpoints/getFollows.lua
  • happyview-modules/lua/endpoints/listActorFollowers.lua
  • happyview-modules/lua/endpoints/listActorFollowing.lua
  • happyview-modules/lua/endpoints/listBadgeAwards.lua
  • happyview-modules/lua/endpoints/listBadgeDefinitions.lua
  • happyview-modules/lua/endpoints/listBadgeResponses.lua
  • happyview-modules/lua/endpoints/listEvmLinks.lua
  • happyview-modules/lua/endpoints/listFeatures.lua
  • happyview-modules/lua/endpoints/listLocations.lua
  • happyview-modules/lua/endpoints/listOrganizations.lua
  • happyview-modules/lua/endpoints/listProfiles.lua
  • happyview-modules/lua/endpoints/searchBadgeDefinitions.lua
  • happyview-modules/lua/endpoints/searchOrganizations.lua
  • happyview-modules/lua/endpoints/searchProfiles.lua
  • happyview-modules/lua/shared/actorFollow.lua
  • happyview-modules/lua/shared/actorFollowList.lua
  • happyview-modules/lua/shared/actorFollowLookup.lua
  • happyview-modules/lua/shared/organizationList.lua
  • happyview-modules/lua/shared/profileList.lua
  • happyview-modules/lua/src/getFollows.lua
  • happyview-modules/lua/src/listBadgeAwards.lua
  • happyview-modules/lua/src/listBadgeDefinitions.lua
  • happyview-modules/lua/src/listBadgeResponses.lua
  • happyview-modules/lua/src/listEvmLinks.lua
  • happyview-modules/lua/src/listFeatures.lua
  • happyview-modules/lua/src/listLocations.lua
  • happyview-modules/lua/src/searchBadgeDefinitions.lua
  • happyview-modules/modules/actor-follow/manifest.json
  • happyview-modules/modules/badge-definitions/manifest.json
  • happyview-modules/modules/badge-queries/manifest.json
  • happyview-modules/modules/evm-links/manifest.json
  • happyview-modules/modules/features/manifest.json
  • happyview-modules/modules/location/manifest.json
  • happyview-modules/modules/organization/manifest.json
  • happyview-modules/modules/profile/manifest.json
  • happyview-modules/tests/unit/feature.test.js
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@changeset-bot

changeset-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 35cd6de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Kzoeps
Kzoeps force-pushed the lua/list-helpers-batch2 branch from c8aab2b to 9a07b18 Compare November 18, 2026 14:38
@Kzoeps
Kzoeps force-pushed the lua/list-helpers-batch3 branch from 64cde02 to 55ed073 Compare November 18, 2026 14:39
@Kzoeps
Kzoeps force-pushed the lua/list-helpers-batch2 branch from 9a07b18 to dbf7899 Compare November 18, 2026 15:05
@Kzoeps
Kzoeps force-pushed the lua/list-helpers-batch3 branch from 55ed073 to 1ab135a Compare November 18, 2026 15:05
Base automatically changed from lua/list-helpers-batch2 to main November 18, 2026 15:54
@sonarqubecloud

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@Kzoeps
Kzoeps merged commit 90e8d64 into main Nov 18, 2026
7 of 8 checks passed
@Kzoeps
Kzoeps deleted the lua/list-helpers-batch3 branch November 18, 2026 15:58

This branch was previously deployed

1 inactive deployment
Preview — 35cd6dec Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant