Repository navigation
Fix SchemaParameter.schema type in openapi-3-1 (OasSchema32 -> OasSchema31) - #137
Open
tarunagnihotri534 wants to merge 1 commit into
Open
tarunagnihotri534 wants to merge 1 commit into
tarunagnihotri534 wants to merge 1 commit into
Conversation
jdesrosiers
requested changes
Oct 22, 2026
jdesrosiers
left a comment
Collaborator
There was a problem hiding this comment.
Drop the tests. That's not necessary.
tarunagnihotri534
force-pushed
the
fix/openapi-3-1-schema-parameter-type
branch
from
October 22, 2026 16:08
c8c6bf4 to
5cfcf66
Compare
Author
|
Thanks for the review @jdesrosiers! I've dropped the test file, so the PR is now just the one-line type fix ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a typing error in
openapi-3-1/index.d.tswhereSchemaParameter.schemawas typed asOasSchema32instead ofOasSchema31.Root Cause
SchemaParameterwas copied over fromopenapi-3-2/index.d.tsin commita52c3d0("OpenApi type improvements") and the schema type was never switched back to the 3.1 one.OasSchema32isn't declared or imported inopenapi-3-1/index.d.ts, so anyone type-checking declaration files withskipLibCheck: falsehits this error when importing from@hyperjump/json-schema/openapi-3-1:It went unnoticed because the repo's
tsconfig.jsonhasskipLibCheck: true.Changes
SchemaParameter.schemafromOasSchema32toOasSchema31, matchingMediaType.schemaandHeader.schemain the same file.Verification
openapi-3-1/index.d.tswith--skipLibCheck falseno longer reports theOasSchema32error. The remaining errors from@hyperjump/browserare unrelated and out of scope here.npm run check-typespasses with 0 errors.npm testpasses (28 test files, 15,031 tests passed, 64 skipped).Fixes #135