Repository navigation
Save concurrent dynamic index without consolidate/compact #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuejiaointel
wants to merge
16
commits into
main
Choose a base branch
from
dev/yuejiao/svs257-save-without-compact
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8b7a397
Save concurrent dynamic index without consolidate/compact
yuejiaointel 5e0c57a
Drop changes not needed for save without compact
yuejiaointel e0ef0bc
Keep soft-deleted IDs when saving concurrent dynamic index
yuejiaointel 60472b3
C API: add svs_index_load_stream_dynamic_ex
yuejiaointel 2fd3fee
Drop only soft-deleted mappings when loading into the non-concurrent …
yuejiaointel e79523e
Keep save/load logic in place; branch on index type
yuejiaointel 8053786
Move the consolidate comment into the non-concurrent branch
yuejiaointel 292f21a
Move svs_index_load_stream_dynamic_ex to a separate PR
yuejiaointel ba02cae
Test save/load of a consolidated but not compacted concurrent index
yuejiaointel e3d5215
Reuse the storage lock in save instead of a new writers lock
yuejiaointel fee726f
Drop documentation-only additions
yuejiaointel cfb2a02
Use status_snapshot() in save; drop checks the previous version did n…
yuejiaointel e24bd2e
Add a save lock so searches keep running during save
yuejiaointel 420cb94
Restore README sentence and blank-line layout
yuejiaointel ace05fc
Test loading a concurrent save into the dynamic index
yuejiaointel a3d362f
Merge branch 'main' into dev/yuejiao/svs257-save-without-compact
yuejiaointel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the tests to what save/load preserves. Writer exclusion and searches during save were checked locally (save returns in ~0.02 s with 4 writer threads; searches complete during saves), but a blocking-stream test depends on thread timing, so not adding it here.