Repository navigation
fix: archive what else a worktree's local bin/ holds on prune - #1446
Merged
Merged
Conversation
The notes archive skipped the local tier's whole top-level bin/, so prune reported a merged, clean worktree reclaimed and deleted the only copy of any script a person kept there. It now leaves out only the binary scripts/abcd.sh builds and the <binary>.<pid> file it builds that binary through, a killed build's leftover. Every other file in bin/ is judged as a note, so one the archive cannot vouch for keeps the worktree instead of being lost. Resolves: iss-2611041759314115 Assisted-by: Claude:claude-opus-5-5
Assisted-by: Claude:claude-opus-5-5
A regular file named as the binary or its <binary>.<pid> file was left out on its name alone, so a note a person kept under such a name was still lost. The archive now leaves one out only when it is not text or is past the per-file cap, as a build always is. A short build leftover stays out and text is archived. Also files the lane-removal gap a review found beside this fix. Refs: iss-2611041759314115 Assisted-by: Claude:claude-opus-5-5
Assisted-by: Claude:claude-opus-5-5
The rule that a file the walk cannot read is no build product had no test, and loosening it would have lost that file silently. Also corrects the lane-removal record, which missed the second site that removes a lane's worktree. Refs: iss-2611041759314115 Refs: iss-2611070853292700 Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notes archive skipped the local tier's whole top-level bin/, so prune reported a merged, clean worktree reclaimed and deleted the only copy of any script a person kept there. It now leaves out only the binary scripts/abcd.sh builds and the . file it builds that binary through, a killed build's leftover. Every other file in bin/ is judged as a note, so one the archive cannot vouch for keeps the worktree instead of being lost.
A file at those two names is left out only when it is not text or is past the archive's per-file cap, as a build always is: text a person kept there is archived, and a file there that cannot be read keeps the worktree. A person's own file over the cap at exactly those names is still left out, as the spec states.
The review also found that a build loop's lane worktree is removed without this archive; that is filed as iss-2611070853292700.
Resolves: iss-2611041759314115
Refs: iss-2611070853292700
Assisted-by: Claude:claude-opus-5-5