Repository navigation
Fix cli wrap test regexps - #72
Merged
Merged
Conversation
…ed accessibility + tests
- Declare total_opportunities_region in utils::globalVariables() (R CMD check NOTE: no visible binding). - Fix the stale doc line: for "total" and "singly", detailed results now include the group_by columns and decay_function_arg. - Remove the commented-out code left in singly_constrained(). - Add a NEWS entry for #66. - Test that each group gets its own regional total against hand-computed values (active, passive, two decay values, K_total), and that grouped results equal standalone runs when groups cover different ids (total and singly, active and passive). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fix issue 66 (1/2) - Fix group_by and multi-decay handling in total and singly constrained accessibility
cli wraps long messages at the console width, so a test regexp with plain spaces fails when a line break falls inside the phrase (seen on a narrow console in "raises a clear error if id types are incompatible"). Use [[:space:]]+ between words, keeping only the distinctive words where the full phrase would pass 80 columns. With this, the suite passes at cli.width = 20, 40 and 80, except "doubly-constrained: errors when totals mismatch", which PR #71 replaces with a wrap-safe version (left untouched here to avoid a conflict). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the test failure @soukhova saw in #71: cli wraps long error messages on narrow consoles, so test patterns with plain spaces could fail. 10 patterns in 7 test files now use [[:space:]]+ between words. Tests only; no package code changes. The “totals mismatch” test is left alone because #71 replaces it.
Tests pass (1,386 checks) and R CMD check gives 0 errors, 0 warnings, 0 notes.