Repository navigation
test: Add modular inversion tests - #1812
Merged
Merged
Conversation
The modular inversion is tested through ModArith::inv() on a few values for each modulus, and through the curve precompiles, whose inversions see random-looking Montgomery forms. Test inv() on random values also for the orders of secp256k1 and P-256 and the P-256 prime, telling the non-invertible values of 2^256 - 1 by its prime factors. Test modinv_scaled() on small values, on values near powers of 2, and on the inputs needing the most divsteps of the safegcd algorithm found for 256 and 384 bits. Add bn254 addition, ecrecover and p256verify vectors whose inversions start from 2^211 or need the most divsteps found for their modulus. The tests come from the safegcd inversion (#1806) and pass with the current binary GCD.
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1812 +/- ##
==========================================
- Coverage 98.23% 98.23% -0.01%
==========================================
Files 186 186
Lines 17144 17192 +48
Branches 3950 3963 +13
==========================================
+ Hits 16842 16888 +46
- Misses 233 235 +2
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modular inversion is tested through ModArith::inv() on a few values
for each modulus, and through the curve precompiles, whose inversions
see random-looking Montgomery forms.
Test inv() on random values also for the orders of secp256k1 and P-256
and the P-256 prime, telling the non-invertible values of 2^256 - 1 by
its prime factors. Test modinv_scaled() on small values, on values near
powers of 2, and on the inputs needing the most divsteps of the safegcd
algorithm found for 256 and 384 bits. Add bn254 addition, ecrecover
and p256verify vectors whose inversions start from 2^211 or need the
most divsteps found for their modulus.
The tests come from the safegcd inversion (#1806) and pass with the
current binary GCD.