Repository navigation
test: Avoid copying RLP-encoded strings - #1816
Merged
Merged
Conversation
rlp::encode(bytes_view) returned the reference that bytes::operator+= gives, so the encoded string was copied into the return value. Append to a local variable instead and return it. This removes an allocation and a copy from most RLP string encodings (transactions, logs, trie nodes) and makes the state tests execute about 0.1% fewer instructions. The copy was found with LLVM's CopyProf (-fcopyprof).
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the RLP string encoder optimization.
No open issues 🎉
What changed in this PR
This PR removes an avoidable copy from the RLP string encoder used by test utilities, reducing encoding overhead without changing the encoded output.
Changes:
- Append input bytes to a local encoded buffer and return it, enabling return-value optimization or move semantics.
| File | Description |
|---|---|
test/utils/rlp.hpp |
Return a local RLP buffer instead of copying the reference returned by operator+=. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1816 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 186 186
Lines 17192 17194 +2
Branches 3963 3963
=======================================
+ Hits 16888 16890 +2
Misses 235 235
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rlp::encode(bytes_view) returned the reference that bytes::operator+= gives, so the encoded string was copied into the return value. Append to a local variable instead and return it.
This removes an allocation and a copy from most RLP string encodings (transactions, logs, trie nodes) and makes the state tests execute about 0.1% fewer instructions. The copy was found with LLVM's CopyProf (-fcopyprof).