Repository navigation
Conversation
The state and blockchain test loaders read JSON strings with get<std::string>(), which copies each string only to parse or compare it. Use get_ref<const std::string&>() to reference the string stored in the JSON document instead. A non-string value still throws json::type_error, only with a different message. This removes an allocation and a copy from loading most test values and makes the state tests execute about 0.1% fewer instructions. The copies were found with LLVM's CopyProf (-fcopyprof).
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues requiring changes.
No open issues 🎉
What changed in this PR
Reduces unnecessary string allocations and copies in the state and blockchain test loaders by reading strings directly from the JSON document.
Changes:
- Replaces
get<std::string>()withget_ref<const std::string&>()for parsing, comparisons, and expected-exception mapping. - Preserves
json::type_errorfor non-string inputs, with different diagnostic wording.
| File | Description |
|---|---|
test/utils/statetest_loader.cpp |
Borrows JSON strings for shared value conversions, destination checks, and exception mapping. |
test/utils/blockchaintest_loader.cpp |
Borrows expected-exception strings before mapping them. |
Review effort: Balanced
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1817 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 186 186
Lines 17192 17192
Branches 3963 3963
=======================================
Hits 16888 16888
Misses 235 235
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
Not worth it, we plan to migrate JSON library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state and blockchain test loaders read JSON strings with getstd::string(), which copies each string only to parse or compare it. Use get_ref<const std::string&>() to reference the string stored in the JSON document instead. A non-string value still throws json::type_error, only with a different message.
This removes an allocation and a copy from loading most test values and makes the state tests execute about 0.1% fewer instructions. The copies were found with LLVM's CopyProf (-fcopyprof).