Repository navigation
trigger the publish workflow on an unpublished version - #212
Merged
Merged
Conversation
`release.yml` ran on every push to `master`: a full `make ci` (duplicating `build.yml`, which
already ran the same pipeline on the PR) followed by a `release` environment approval
request, whether or not the commit changed the version.
The workflow now asks crates.io whether the current version is published and does nothing
when it is. A commit-message gate ("release: ...") was considered and rejected: squash
merges replace the message with the PR title, which drops the prefix and makes the workflow
skip a real release while reporting success. The version not being on the index cannot be
lost by a merge strategy.
Also skip the workflow on forks, where it can only fail for lack of publish credentials
(reported in #147), and add `workflow_dispatch` to re-run a release that failed partway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.ymlran on every push tomaster: a fullmake ci(duplicatingbuild.yml, whichalready ran the same pipeline on the PR) followed by a
releaseenvironment approval request,whether or not the commit changed the version.
make cigate and the environment approval now happen only for a version that is actuallygoing out.
update
extract_into(), add example for bundles and addrestart()method #147).workflow_dispatch, to re-run a release whose earlier attempt failed partway.A commit-message gate (
release: ...) was considered and rejected: squash merges replace themessage with the PR title, which drops the prefix and makes the workflow skip a real release while
reporting success.
cachedhit exactly that and moved to this check in jaemk/cached#303. A versionthat is not on the index cannot be lost by a merge strategy.
Verified against the live API:
1.2.0resolves to "already published, nothing to release", and anunpublished version resolves to "releasing".