Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_number()currently converts strings such asNaN,Infinity, and overflowing exponents into non-finite floats. They then survive numeric projections and cannot be emitted as valid JSON with a strict encoder.Return null when a string-to-float conversion produces a non-finite result. Integer conversion, finite floats, and number inputs retain their current behavior. This follows the specification's JSON result contract and its implementation-specific floating-point range, and allows projections to filter these unsuccessful conversions as usual.
Eight string conversion cases and a projection fail before the fix. The full unit/compliance suite passes: 993 passed, 1 skipped, and 8 subtests passed.
git diff --checkalso passes. No hosted CI result is claimed.