Repository navigation
fix(auth): handle malformed base64 without Buffer - #110
Open
awais-ur-rehman wants to merge 1 commit into
Open
awais-ur-rehman wants to merge 1 commit into
awais-ur-rehman wants to merge 1 commit into
Conversation
blakeembrey
requested changes
Oct 27, 2026
blakeembrey
left a comment
Member
There was a problem hiding this comment.
This is a great fix, but the approach isn't what I'd recommend. Can you instead align the implementation within base64.ts? It should return an empty string to align with node behavior, and keep the catch out of the main code path for node.
There's also already a test file you can update to cover both cases.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
Bufferis unavailable, malformed base64 credentials such asBasic YorBasic .make the nativeUint8Array.fromBase64decoder throw instead of returning the documentedundefinedresult. Catch decode failures inparse(), with regression tests covering invalid characters, incomplete base64, and valid credentials through the browser decoder.Breaking Changes
None.
Testing
npm exec --yes --package=node@latest -- npm teston Node 26.12.1 — 35 tests passed, none skipped, with nativeUint8Array.fromBase64; 100% statement, branch, function, and line coverage.npm teston Node 24.13.0 — 30 passed; five browser-decoder tests skipped because this runtime does not expose the Uint8Array base64 APIs.git diff --checkUint8Array.fromBase64, setglobalThis.Buffer = undefinedbefore importingbasic-auth, then callparse('Basic Y'); it now returnsundefined.