Repository navigation
Fix annotations on methods that return Stream<@Nullable Object[]> - #6213
Merged
mpkorstanje merged 1 commit intoOct 28, 2026
Merged
Conversation
Signed-off-by: Manu Sridharan <msridhar@gmail.com>
✅ All tests passed ✅🏷️ Commit: 74338c7 Learn more about TestLens at testlens.app/docs. |
marcphilipp
pushed a commit
that referenced
this pull request
Oct 29, 2026
Previously, NullAway warnings blocked the build due to `-Werror`. By setting NullAway to error directly, more warnings get emitted in a single build (due to google/error-prone#4546). I noticed this while working on #6213. Signed-off-by: Manu Sridharan <msridhar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NullAway will warn on all of these cases once uber/NullAway#2080 lands.
Arguments::getreferences a method that returns@Nullable Object[], so all the return types of these methods should beStream<@Nullable Object[]>. No logic changes, just annotations and formatting.