Repository navigation
ci: Report rejected changes to done nodes - #1663
Merged
nuclearcat merged 1 commit intoOct 29, 2026
Merged
Conversation
kernelci-api rejects state/result changes to nodes that are already done and publishes each attempt (and each admin override) on the node-integrity channel. Such nodes may hold a wrong result in Maestro or on the dashboard and need a manual look. Add tests/check_node_integrity.py to list those events for the validation window, run it in the forecast job, and include them in the Discord summary with a link to each affected node. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernelci-api (kernelci/kernelci-api#726) rejects state/result changes to nodes that are already done and publishes each attempt, including admin overrides, on the
node-integritychannel. Such nodes may hold the wrong result in Maestro or on the dashboard.tests/check_node_integrity.pylistsnode-integrityevents from the validation window via/events?channel=node-integrity. It fails if there are any.forecastjob, and its report is uploaded alongsideforecast.json.Testing