Repository navigation
ci: run analyze and test on PRs and pushes to main - #9
Merged
Merged
Conversation
Dart-level checks only: pub get, analyze, test. No Android/APK job — the ZCS SmartPos jars and native libs are proprietary and gitignored, so a Kotlin compile cannot succeed on a clean clone. Flutter is pinned to 3.44.4 rather than following `stable`, since pubspec only gives a floor (>=3.29.0). SDK and pub caches are both on, with the pub cache keyed on pubspec.lock so it refreshes when dependencies change. `dart format --set-exit-if-changed` is left out: lib/domain/ticket/gift.dart does not currently satisfy it, and reformatting was out of scope. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the repo's first GitHub Actions workflow. There was no
.github/directory before this; the only verification on a release was runningflutter analyzeandflutter testby hand.What runs
.github/workflows/ci.yml— one job, on every PR tomainand every push tomain:flutter pub getflutter analyzeflutter testAll three verified locally on a clean tree before writing the workflow: analyze reports no issues, 110 tests pass.
Deliberate omissions
No Android/APK job. The ZCS SmartPos SDK jars (
android/app/libs/) and native libs (android/app/src/main/jniLibs/) are proprietary, not redistributable and gitignored.MainActivity.ktimportscom.zcs.sdkunconditionally, so the Kotlin compile cannot succeed on a clean clone. Android builds stay on a machine that has the SDK — see The proprietary bits.No
dart format --set-exit-if-changed. The tree does not currently satisfy it —lib/domain/ticket/gift.dartdiffers (7 insertions, 4 deletions, all line-wrapping). Reformatting was out of scope, so the step is left out with a comment saying what to do first. Easy follow-up if you want it enforced.Both omissions are commented in the workflow so the next person doesn't add them and turn CI red.
Version pinning and caching
Flutter is pinned to 3.44.4 — the version this project is developed against — rather than tracking
stable, sincepubspec.yamlonly sets a floor (flutter: ">=3.29.0"). The version lives in oneenvvar.Both caches are on:
cache: truefor the Flutter SDK andpub-cache: truefor pub packages. The pub cache key includeshashFiles('pubspec.lock'), because the action's default key is scoped only to OS/channel/version/arch and so would never refresh when dependencies change.Workflow passes
actionlintclean.🤖 Generated with Claude Code