Repository navigation
fix(lance-tools): add dataset file verification and recovery - #10548
Open
lance-gatefixer[bot] wants to merge 3 commits into
Open
lance-gatefixer[bot] wants to merge 3 commits into
lance-gatefixer[bot] wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
Applied the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operators lack dataset CLI commands to identify missing or damaged data files and remove their references from a manifest.
Add
dataset verify-data-files,repair-manifest,locate-data-file, andrestore. Verification checks every referenced object's size and optionally its current-format metadata. Repair validates every explicit file selection, previews affected fragments with--dry-run, and removes whole fragments through a normal delete transaction. File resolution uses the dataset's registered storage bases, including shallow clones. Storage options and optional cloud provider features support remote datasets.Removing a fragment drops all its rows and columns from the new version; physical objects and historical manifests remain intact. Repair commits skip automatic cleanup so retention settings cannot delete recovery history during repair. Deep verification checks metadata, not every data page or blob payload. The README documents these limits and the recovery commands.
Adding
Datasetto the publicLanceToolsCommandenum requires callers with exhaustive matches to handle the new variant (breaking-change).Validation:
cargo test -p lance-tools --profile ci --locked— 32 tests passed, including recovery, history preservation under automatic cleanup, table-manifest dispatch, and manifest fixture parsing.cargo fmt --all -- --check— passed.cargo clippy --all --tests --benches --profile ci --locked -- -D warnings— passed.RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --profile ci --locked— passed.Fixes #6694