Repository navigation
perf(index): answer the FTS row-order check from a cached invalid verdict - #10553
Open
LuciferYang wants to merge 3 commits into
Open
LuciferYang wants to merge 3 commits into
LuciferYang wants to merge 3 commits into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
lance-gatekeeper
Bot
added
the
K-approved
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10551.
dense_and_strictly_ascendingnow returnsfalsestraight from a cachedDuplicateorOutOfOrderverdict. Before, it askedtry_ordered_row_addressesfor the ordered view, which rescans the documents up to the first violation to rebuild the error, and then discarded the error. Callers that need the diagnostics still get them fromtry_ordered_row_addresses, andUnknownandOrderedverdicts take the same path as before.On a 10M-document projection whose first violation is at document 5M, a call with a cached
OutOfOrderverdict goes from 9.7 ms to 41 ns in a release build. combined_fields search makes two or three such calls per partition per query, inline on the query thread.How was this patch tested
ascending_address_gate_requires_live_slots_and_strict_ordernow calls the check a second time and asserts that the validation visit counter does not move. The three cases with a duplicate or out-of-order address fail without the change.