Repository navigation
perf(index)!: parallelize zone statistics computation in scalar index training - #8469
Conversation
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-changes
lance-gatekeeper
Bot
removed
the
K-changes
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
K-approved
zhangyue19921010
changed the title
lance-gatekeeper
Bot
removed
K-approved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-approved
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
lance-gatekeeper
Bot
removed
the
K-approved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
K-approved
lance-gatekeeper
Bot
removed
the
K-approved
lance-gatekeeper
Bot
added
the
K-approved
|
Hi @Xuanwo CI passed and lance-gatekeeper approved. Would u mind to take a look? Thanks! |
lance-gatekeeper
Bot
added
K-approved
lance-gatekeeper
Bot
removed
the
K-approved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-approved
lance-gatekeeper
Bot
removed
the
K-approved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-approved
|
Hold until zonemap v1 landed. |
lance-gatekeeper
Bot
removed
the
K-approved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-approved
lance-gatekeeper
Bot
removed
the
K-approved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-approved
lance-gatekeeper
Bot
removed
the
K-approved
There was a problem hiding this comment.
✅ Gate recommendation: approve.
ZoneMap v1 is now merged into this base, satisfying the requested hold for v1. The updated trainers preserve aligned seed/scan zone boundaries and optional null tracking while retaining ordered, bounded parallel dispatch and the sequential trainer's borrowed, non-Send support.
lance-gatekeeper
Bot
added
the
K-approved
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Approved on the verified head after hosted CI and Gatekeeper completed.
The change preserves the current-main aligned/null and ZoneMap V1/seed paths, retains the existing processor-based ZoneTrainer API, and adds ordered bounded parallel training with regression coverage. Training-only benchmark verification is limited to the measured 8M-row UTF-8, 64-fragment zonemap workload.
Closes: #8468