Repository navigation
Fix php:logs 404 by using the correct Forge log key - #177
Open
19singh96sunny-max wants to merge 1 commit into
Open
19singh96sunny-max wants to merge 1 commit into
19singh96sunny-max wants to merge 1 commit into
Conversation
The php:logs command requested the server log with forgeKey() (e.g. "php84"),
but Forge's log endpoint expects the hyphenated key "php-8.4" — matching the
existing "nginx-error" and "database-mysql" log keys — and returns a 404
otherwise.
Add a dedicated PhpVersion::logKey() that returns "php-{release}" and use it in
PhpLogsCommand. forgeKey() is left unchanged because php:restart still relies on
the "php84" form for the PHP reboot endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175.
php:logsrequests the server log usingPhpVersion::forgeKey(), which returnsphp84. Forge's log endpoint expects the hyphenated keyphp-8.4(consistent with the existingnginx-erroranddatabase-mysqllog keys), so the request 404s.This adds a dedicated
PhpVersion::logKey()returningphp-{release}and uses it inPhpLogsCommand.forgeKey()is intentionally left unchanged, sincephp:restartrelies on thephp84form for the reboot endpoint.Added a
logKey()unit test and updated thephp:logsfeature test to assert the corrected key.