Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 18, 2026 21:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ast_utils.create_transformer()accepts an initial transformer whose existing callbacks are retained while AST constructors are added. It currently replaces that object whenever it is falsey. For example, a transformer implementing__len__over an initially empty symbol table loses its token/rule callbacks and state, so the same code behaves differently depending on whether the table is populated.Only construct a new
Transformerwhen the argument isNone. Add regression coverage for empty and populated state, preservation of instance identity, existing token and rule callbacks working together with the generated AST constructor, and the omitted/explicit-None defaults.Validation on Linux:
git diff --checkpass.Other platforms and interpreter versions have not been checked locally. No hosted-CI pass is claimed.
Prepared and tested with OpenAI Codex assistance.