Repository navigation
ci: make the libsemigroups branch configurable via reusable workflows - #540
james-d-mitchell wants to merge 1 commit into
Conversation
The workflows that build libsemigroups from git (tests, pip, config-options, doc, lint) are now reusable workflows taking a required libsemigroups-branch input (and an optional libsemigroups-repo input). They are called from the new ci.yml, which sets the branch once, so that stable branches of libsemigroups_pybind11 can test against the matching stable branch of libsemigroups. custom-branch.yml now calls tests.yml. AI assistance: Claude Code (Claude Opus 5.5) wrote these workflow changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Joseph-Edwards
left a comment
There was a problem hiding this comment.
I am happy with most of the changes here, other than some small comment related issues and maybe an unnecessary file. This PR doesn't add the changes the make pull requests that are opened into stable-* use a different version of libsemigroups. Will that change come in a different PR?
There was a problem hiding this comment.
This file feels unnecessary now. Would it be possible to delete the file and and a workflow_dispatch trigger to test.yml?
| name: Check documentation builds | ||
| on: [pull_request, workflow_dispatch] | ||
| on: | ||
| # This workflow is called by ci.yml and custom-branch.yml, which specify the |
There was a problem hiding this comment.
I don't think this workflow is called in custom-branch.yml.
| name: Lint | ||
| on: [pull_request, workflow_dispatch] | ||
| on: | ||
| # This workflow is called by ci.yml and custom-branch.yml, which specify the |
There was a problem hiding this comment.
Same comment as above
| name: Run tests (pip) | ||
| on: [pull_request, workflow_dispatch] | ||
| on: | ||
| # This workflow is called by ci.yml and custom-branch.yml, which specify the |
There was a problem hiding this comment.
Same comment as above
|
I am also a little bit suspicious of the 19 pending checks we currently have on this PR. I suspect it is something that relates to the fact that we are modifying workflows, but it's worth double checking that some workflows aren't being triggered twice or something weird like that. |
Thanks @Joseph-Edwards the pending checks are the ones that we've (well I've) configured as being "required", i.e. they are the old checks that no longer exist and as soon as I remove them from being "required" they will disappear. |
The workflows that build libsemigroups from git (tests, pip, config-options, doc, lint) are now reusable workflows taking a required libsemigroups-branch input (and an optional libsemigroups-repo input). They are called from the new ci.yml, which sets the branch once, so that stable branches of libsemigroups_pybind11 can test against the matching stable branch of libsemigroups. custom-branch.yml now calls tests.yml.
AI assistance: Claude Code (Claude Opus 5.5) wrote these workflow changes.