Repository navigation
Conversation
The Meson shim delegates to the CMake build without forwarding the requested library type, so default_library=static still produced shared libraries. Forward BUILD_SHARED_LIBS=OFF when static is requested; the default shared build is unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIDAPI's Meson build hands the work to CMake, but it currently drops Meson's default_library choice on the floor. Asking for -Ddefault_library=static still builds a shared library, which breaks downstream/wrap builds that need static linking.
The CMake project already understands BUILD_SHARED_LIBS, so forward OFF when static is requested. Shared remains the default and is unchanged.