Repository navigation
Conversation
|
Skipping CI for Draft Pull Request. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates startDeviceManager so an existing minimized device manager window is restored to normal state and activated, while preserving the behavior for already visible windows. Sequence diagram for restoring the device manager windowsequenceDiagram
participant Caller
participant SingleDeviceManager
participant MainWindow
Caller->>SingleDeviceManager: startDeviceManager(pageDescription)
SingleDeviceManager->>MainWindow: setWindowState(...)
SingleDeviceManager->>MainWindow: activateWindow()
SingleDeviceManager->>MainWindow: showNormal()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1. Root cause: a single-line `//` comment silently disabled both `activateWindow()` and `showNormal()` in startDeviceManager 2. Fix: uncomment both calls and split them onto separate lines to prevent future single-line comment from swallowing multiple statements 3. Impact: minimized windows now properly restore and gain focus when startDeviceManager is called via D-Bus, consistent with the `activateWindow()` method already used in the same file Log: Fixed window not restoring from minimized state when device manager is called again Influence: 1. Test calling startDeviceManager when window is minimized 2. Verify window restores to normal state and gains focus 3. Test calling startDeviceManager when window is already visible fix: 恢复 startDeviceManager 中被注释的窗口激活调用 1. 根因:第 87 行单行 `//` 注释同时吞掉了 `activateWindow()` 和 `showNormal()` 两条调用,导致窗口最小化时无法被唤起 2. 方案:取消注释并将两条调用拆分到独立行,从结构上消除单行 注释吞掉多条语句的隐患 3. 影响:最小化状态下再次调用 startDeviceManager 时窗口可正常 恢复并激活,与同文件 `activateWindow()` 方法行为一致 Log: 修复设备管理器最小化状态下再次调用无法恢复窗口的问题 Influence: 1. 测试窗口最小化时调用 startDeviceManager 的恢复行为 2. 验证窗口恢复为正常状态并获得焦点 3. 测试窗口已可见时调用 startDeviceManager 的行为
The license-check CI (SPDX Header Validation) requires files created in earlier years and modified in 2026 to carry a copyright year range ending with the current year. Extend the SPDX-FileCopyrightText header of SingleDeviceManager.cpp from 2022 to 2022-2026 so the SPDX summary reports 0 failures.
85030dc to
f797328
Compare
|
TAG Bot New tag: 6.0.75 |
fix: uncomment activateWindow/showNormal calls
//comment silently disabled bothactivateWindow()andshowNormal()in startDeviceManagerprevent future single-line comment from swallowing multiple statements
startDeviceManager is called via D-Bus, consistent with the
activateWindow()method already used in the same fileLog: Fixed window not restoring from minimized state when device manager is called again
Influence:
fix: 恢复 startDeviceManager 中被注释的窗口激活调用
//注释同时吞掉了activateWindow()和
showNormal()两条调用,导致窗口最小化时无法被唤起注释吞掉多条语句的隐患
恢复并激活,与同文件
activateWindow()方法行为一致Log: 修复设备管理器最小化状态下再次调用无法恢复窗口的问题
Influence:
Summary by Sourcery
Ensure repeated device manager launches restore and activate the existing window.
Bug Fixes:
Chores: