Repository navigation
test(DeviceInput): 同步 getPS2Syspath 用例断言至修复后正则行为 - #902
Merged
Merged
Conversation
DEF-DM-001(getPS2Syspath 非 i2c 分支贪婪正则)已由 PR linuxdeepin#845 修复并合入 master(统一正则 /input/input[0-9]{1,2}), 原用例断言的是修复前实测的 多一级 /input 捕获行为, 现更新为修复后的正确提取值, 与 i2c 分支一致。 Log: 断言值由 /devices/platform/i8042/serio1/input 更新为 /devices/platform/i8042/serio1, 注释同步说明缺陷已修复 Influence: 仅测试断言, 无生产代码改动; 全套件 153/153 通过
Reviewer's guide (collapsed on small PRs)Reviewer's Guide本 PR 仅更新一个单元测试文件,使 getPS2Syspath 的非 i2c 场景断言匹配已合入的正则修复结果;不涉及生产代码,并据描述已通过范围内 5 个套件的 153 个用例。 File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本次变更无需修复,代码正确。测试断言已与修复后的正则行为保持一致。本报告由 AI 代码审查工具自动生成 |
lzwind
approved these changes
Oct 26, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
同步
getPS2Syspath用例断言至修复后的正则行为。仅改动 1 个测试源码文件。背景
DeviceInput::getPS2Syspath非 i2c 分支贪婪正则多捕获一级/input,已由 fix: correct PS/2 syspath regex in non-i2c branch #845 修复并合入 master(统一正则S: Sysfs=(.*)/input/input[0-9]{1,2})UT_DeviceInputBus_GetPS2Syspath_EventMatch_ExtractsSysPath断言的是修复前实测的缺陷行为(/serio1/input),修复合入后该断言过期失败改动内容
tests/src/DeviceManager/ut_deviceinput_bus.cpp:断言值由/devices/platform/i8042/serio1/input更新为/devices/platform/i8042/serio1,注释同步说明缺陷已修复,两分支行为一致测试影响
Summary by Sourcery
Align the DeviceInput syspath unit test with the corrected getPS2Syspath behavior.
Enhancements:
Tests: