[add-uos]

What this PR does

Follow-up to the PageOverview test rewrite (#913) and the off-by-one fix (#862).

#862 changed PageOverview::updateInfo from setColumnAndRow(row - 1) to setColumnAndRow(row + 1) after the rewritten tests had already been merged. The merged case UT_PageOverview.updateInfo_emptyMap_rowMinusOne still pinned the old semantics (empty map → stub receives -1), so it fails on current master (verified locally before this change: [ FAILED ] UT_PageOverview.updateInfo_emptyMap_rowMinusOne).

This PR updates the case to the fixed semantics and refreshes the stale row - 1 comments:

• rename updateInfo_emptyMap_rowMinusOne → updateInfo_emptyMap_passesRowPlusOne
• assert g_colRow == 1 (empty map → row 0 → row + 1)
• update the row - 1 remarks in clearWidgets_clearsTable and updateInfo_overviewSkipped_displayWritten

Test code only; no production changes.

Verification

QT_QPA_PLATFORM=offscreen ./deepin-devicemanager-test \
  --gtest_filter='UT_PageSingleInfo*:UT_PageMultiInfo*:UT_PageOverview*:UT_PageBoardInfo*'
# [  PASSED  ] 107 tests  (PageSingleInfo 39, PageMultiInfo 34, PageOverview 17, PageBoardInfo 17)

Summary by Sourcery

Align PageOverview test expectations with the corrected row handling.

Enhancements:

• Align PageOverview tests and comments with the corrected row-offset behavior so empty-map updates expect the adjusted row value.

Tests:

• Update the PageOverview empty-map test name and assertion to verify the corrected row semantics.

[sourcery-ai]

Sorry @add-uos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 1 day and 19 hours by commenting @sourcery-ai review. Upgrade to get a review now.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This test-only PR updates PageOverview expectations and documentation to match the existing row + 1 off-by-one fix, including changing the empty-map expectation from -1 to 1; the targeted page test suite passes all 107 tests.

File-Level Changes

Change	Details	Files
Align the PageOverview empty-map test with the production row + 1 semantics.	Rename the test to describe the row + 1 behavior. Change the expected stubbed row from -1 to 1 for an empty map. Retain the no-crash assertion while validating the corrected value.	deepin-devicemanager/tests/src/Page/ut_pageoverview.cpp
Refresh PageOverview test comments to document the fixed indexing behavior.	Update clearWidgets comments to explain valid multi-row writes and post-clear emptiness. Remove stale row - 1/out-of-bounds explanations from the overview-skipped case.	deepin-devicemanager/tests/src/Page/ut_pageoverview.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

🤖 AI 代码审查报告

总体评分： 100 分 (通过阈值: 70分)

---

📊 总体评价

项目	结果
审查结论	代码审查通过
评分详情	本次提交为测试文件变更，目的是将 PageOverview 单元测试的期望值与 PR #862 的 off-by-one 修复（setColumnAndRow 从 row-1 改为 row+1）对齐。 变更仅涉及注释更新、测试名称重命名及一个断言期望值修正（-1 → 1），逻辑正确，无安全漏洞，代码质量良好。

---

🔍 详细分析

1. 语法逻辑 ✅

评价： 语法正确，逻辑清晰 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

2. 代码质量 ✅

评价： 代码结构清晰，注释完整 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

3. 代码性能 ✅

评价： 性能良好，资源使用合理 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

4. 代码安全 🔒

评价： 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情：
✅ 未发现安全漏洞

建议： []

---

💡 改进建议代码示例

本次变更无需修复，代码正确。测试期望值已与 PR #862 修复后的语义对齐。

---

本报告由 AI 代码审查工具自动生成

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[add-uos]

/forcemerge

[deepin-bot]

This pr force merged! (status: unknown)