Skip to content

fix: remove deepin-home from Pre-Depends - #68

Merged
Zeno-sole merged 1 commit into
linuxdeepin:masterfrom
lchjvvj:master
Oct 26, 2026
Merged

fix: remove deepin-home from Pre-Depends#68
Zeno-sole merged 1 commit into
linuxdeepin:masterfrom
lchjvvj:master

Conversation

@lchjvvj

@lchjvvj lchjvvj commented Oct 25, 2026 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Bug Fixes:

  • Prevent purging deepin-home from unintentionally removing deepin-default-settings.

@sourcery-ai

sourcery-ai Bot commented Oct 25, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates Debian packaging metadata and documents the change so that purging deepin-home no longer unintentionally removes deepin-default-settings.

File-Level Changes

Change Details Files
Adjust Debian package metadata to prevent purging deepin-home from removing deepin-default-settings.
  • Update package relationship declarations to correct the purge behavior.
  • Record the fix in the Debian changelog.
 debian/control
debian/changelog
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

deepin-ci-robot commented Oct 25, 2026

Copy link
Copy Markdown

Hi @lchjvvj. Thanks for your PR. 😃

@github-actions

github-actions Bot commented Oct 25, 2026

Copy link
Copy Markdown

TAG Bot

TAG: 2026.10.25
EXISTED: no
DISTRIBUTION: unstable

sourcery-ai[bot]
sourcery-ai Bot reviewed Oct 25, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

deepin-ci-robot commented Oct 25, 2026

Copy link
Copy Markdown

Hi @lchjvvj. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Zeno-sole

Zeno-sole commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

/integrate

@github-actions

github-actions Bot commented Oct 26, 2026

Copy link
Copy Markdown

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#4695
PrNumber: 4695
PrBranch: auto-integration-40254952237

@deepin-community-ci-bot deepin-community-ci-bot Bot mentioned this pull request Oct 26, 2026
Open
@Zeno-sole

Zeno-sole commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

commit 格式存在问题 ，ci检查不通过，请参考 linuxdeepin/deepin-system-monitor#595 格式修改一下 @lchjvvj

@lchjvvj

lchjvvj commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

commit 格式存在问题 ，ci检查不通过，请参考 linuxdeepin/deepin-system-monitor#595 格式修改一下 @lchjvvj

？

@Zeno-sole

Zeno-sole commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

commit 格式存在问题 ，ci检查不通过，请参考 linuxdeepin/deepin-system-monitor#595 格式修改一下 @lchjvvj

？

需要修改一下commit格式，不然这个ci门禁过不了 无法合入

@lchjvvj @Zeno-sole
fix: remove deepin-home from Pre-Depends
3aa16ea 
Drop the deepin-home (>= 1.6.0) Pre-Depends entry from debian/control
so that purging deepin-home no longer cascades to
deepin-default-settings.
Bump the package version to 2026.10.25 and record the change in
debian/changelog.

Log: Removed deepin-home Pre-Depends to avoid cascading package removal

Influence:
1. Verify deepin-default-settings installs without deepin-home
2. Verify apt purge deepin-home keeps deepin-default-settings installed
3. Check build dependencies and packaging metadata
4. Confirm the changelog version and entry are correct

fix: 移除 deepin-home 的 Pre-Depends 依赖

从 debian/control 中删除 deepin-home (>= 1.6.0) 的 Pre-Depends 依赖，
避免 apt purge deepin-home 时连带卸载 deepin-default-settings。
将包版本更新为 2026.10.25 并同步更新 debian/changelog。

Log: 移除 deepin-home 的 Pre-Depends 依赖，避免连带卸载

Influence:
1. 验证不安装 deepin-home 时 deepin-default-settings 可正常安装
2. 验证 apt purge deepin-home 后 deepin-default-settings 仍保留
3. 检查构建依赖与打包元数据
4. 确认 changelog 版本号与条目正确

repo: default-settings #master
@lchjvvj

lchjvvj commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

commit 格式存在问题 ，ci检查不通过，请参考 linuxdeepin/deepin-system-monitor#595 格式修改一下 @lchjvvj

？

需要修改一下commit格式，不然这个ci门禁过不了 无法合入

到底是什么问题？

@lchjvvj lchjvvj changed the title fix: apt purge deepin-home 连带卸载 deepin-default-settings fix: remove deepin-home from Pre-Depends Oct 26, 2026
@deepin-ci-robot

deepin-ci-robot commented Oct 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lchjvvj, Zeno-sole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Zeno-sole
Zeno-sole merged commit 95b4c4b into linuxdeepin:master Oct 26, 2026
13 checks passed
@deepin-bot

deepin-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

✅ Tag created successfully

📋 Tag Details
  • Tag Name: 2026.10.25
  • Tag SHA: 22585558dd6b44690e442fc40b742a39eb89dd2c
  • Commit SHA: 95b4c4b28bf0d6e2273d5ca0934ca4f9874eafc8
  • Tag Message: 
    Release default-settings 2026.10.25
  • Tagger:
    • Name: lchjvvj
  • Distribution: unstable

This was referenced Oct 26, 2026
Open
Draft
Open
@BLumia

BLumia commented Oct 30, 2026

Copy link
Copy Markdown
Member

changelog 的修改有问题，应该追加新的 release 信息而不是修改以前的。后续如果要进行别的代码贡献的话请注意这个问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
@Zeno-sole Zeno-sole Zeno-sole approved these changes

Assignees

No one assigned

Labels

approved needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lchjvvj @deepin-ci-robot @Zeno-sole @BLumia