Repository navigation
sound applet: Keep the seek position when the player resends the same track - #14154
Open
mateuscmtropical wants to merge 1 commit into
Open
mateuscmtropical wants to merge 1 commit into
mateuscmtropical wants to merge 1 commit into
Conversation
|
thank you brother |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14127
Some players (MPD through mpDris2) resend
Metadatafor the current track after a seek._setMetadata()then callsSeeker.setTrack(), which always reset the position to 0, so the slider jumped back until the next sync about 10 seconds later.setTrack()now only resets the position when the track ID changes. For the same track it asks the player for the real position instead. This is the fix suggested in the issue by @J426O.Checked the new
setTrack()with a small stub: a new or empty track ID still resets to 0, and the same track ID keeps the position and calls_getPosition(). I did not test it on a live Cinnamon session.