Repository navigation
Allow app launcher shortcuts while a menu is open - #14158
Closed
SeniorMatt wants to merge 2 commits into
Closed
SeniorMatt wants to merge 2 commits into
SeniorMatt wants to merge 2 commits into
Conversation
With the menu open, pressing the Terminal shortcut (for example Super+Shift+C) did nothing and a "C" appeared in the search entry instead. Custom keybindings are allowed in POPUP mode, but the built-in launcher media keys (Home, Calculator, Search, Email, Help, Terminal, WWW) were NORMAL only. While a menu holds the modal grab, Main._stageEventHandler dropped them and passed the key on to whatever had key focus. Allow the launchers in POPUP mode too. A launcher started this way closes the menu first, so the new window doesn't open behind it. Do the same for custom keybindings, which were already allowed but left the menu open.
In an entry, Super+letter combinations that aren't bound to anything, or whose binding isn't allowed in the current action mode, insert the letter. With the menu open, Super+Shift+C typed "C" into the search entry. ClutterText only skips keys pressed with Control. Super is never used to type text, so stop those key presses in the entry's captured-event handler, before ClutterText sees them. Input method events still go through. Shortcuts are unaffected, since Main._stageEventHandler runs before the entry.
Member
|
I don't see a point to this, other than 'you can', and it potentially complicates grabs and keybindings in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the menu open, Super+Shift+C (my terminal shortcut) did nothing and typed "C" into the search box instead.
Similar idea to #13952. Tested on Mint 27 (Wayland): the shortcuts work with the menu open, and typing and searching in the menu are unchanged.