Repository navigation
menu@cinnamon.org: Don't show all app buttons after the menu has already closed - #14161
Open
SeniorMatt wants to merge 1 commit into
Open
SeniorMatt wants to merge 1 commit into
SeniorMatt wants to merge 1 commit into
Conversation
…ady closed. The idle callback that shows the buttons beyond the initial batch could run after a quick close. As the buttons are only hidden again when a close animation finishes, the next open then started with every button visible and had to lay them all out synchronously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the menu opens, an idle callback shows the rest of the app buttons. If the menu is closed again quickly, that callback can still run after the close. The buttons only get hidden again when the close animation finishes, so the next open starts with every button visible and lays them all out at once, which is a visible hitch on a slow CPU.
The fix just returns early when the menu isn't open anymore.
Tested on a ThinkPad T14s Gen 2 in power-saver mode (Mint 27, Wayland), together with #14159 and #14160: the menu opens smoothly now.