Skip to content

menu@cinnamon.org: Don't show all app buttons after the menu has already closed - #14161

Open
SeniorMatt wants to merge 1 commit into
linuxmint:masterfrom
SeniorMatt:panel-menu-performance
Open

SeniorMatt wants to merge 1 commit into
linuxmint:masterfrom
SeniorMatt:panel-menu-performance

Conversation

@SeniorMatt

Copy link
Copy Markdown

After the menu opens, an idle callback shows the rest of the app buttons. If the menu is closed again quickly, that callback can still run after the close. The buttons only get hidden again when the close animation finishes, so the next open starts with every button visible and lays them all out at once, which is a visible hitch on a slow CPU.

The fix just returns early when the menu isn't open anymore.

Tested on a ThinkPad T14s Gen 2 in power-saver mode (Mint 27, Wayland), together with #14159 and #14160: the menu opens smoothly now.

…ady closed.

The idle callback that shows the buttons beyond the initial batch could
run after a quick close. As the buttons are only hidden again when a
close animation finishes, the next open then started with every button
visible and had to lay them all out synchronously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant