Repository navigation
appswitcher: Destroy the background actor when closing the 3D switchers - #14162
Open
MNCloudwerksTechnology wants to merge 1 commit into
Open
MNCloudwerksTechnology wants to merge 1 commit into
MNCloudwerksTechnology wants to merge 1 commit into
Conversation
AppSwitcher3D creates a new full-screen background in _init() on every Alt-Tab, but _destroyActors() only removed it from Main.switcherGroup and never destroyed it. Every Coverflow/Timeline invocation therefore leaked its background (one per monitor). On X11 the leaked backgrounds stay registered with muffin, so every later wallpaper change runs the background transition and meta_x11_background_set_layer() for all of them on the compositor thread. After a few days of uptime this freezes screen updates for more than a second on each wallpaper change. Destroy and drop the background, as expo.js and overview.js already do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
I rarely shut down my machine and this kept coming back every few days. So i put claude up to the task to investigate. Fixed locally, issue didn't happen ever since. So this is the upstream fix. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AppSwitcher3D(used by the Coverflow and Timeline Alt-Tab switchers) creates a new full-screen background in_init()on every Alt-Tab, but_destroyActors()only removes it fromMain.switcherGroupand never destroys it. Every invocation leaks its background (one per monitor).On X11 the leaked backgrounds stay registered with muffin, so every later wallpaper change runs the background transition and
meta_x11_background_set_layer()(each with an X error trap push/pop) for all of them on the compositor thread. Screen updates stall while this runs, and the stall grows with the number of Alt-Tabs since Cinnamon started.Observed impact
Cinnamon 6.6.9 / muffin 6.6.3, X11, two monitors (7680x1440), Coverflow Alt-Tab:
meta_x11_background_set_layercalls (uprobe count) and froze screen updates for 1.2–1.5 s.set_layercalls with no measurable stall.(6.6.x has the same bug; there the background lives in
global.overlay_group.)Fix
Destroy and drop the background in
_destroyActors(), the same wayexpo.jsandoverview.jsalready tear down theirs.To reproduce
🤖 Generated with Claude Code