Repository navigation
Conversation
A reload published every item of the record, model-only ones among them: a realtime model's placeholder for the person's words reached the host's history, then the transcript told the same id again and the host held it twice, so the next delegation refused the history. Both reloads publish history(), the items the history shows.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: A history reload published every item of the record, model-only ones included, so a realtime model's placeholder for the person's words reached
session.history. The transcript then added the same id again, the host's history held it twice, and the next delegation failed with "item IDs must be nonempty and unique".Fix: Both reloads, after a turn takes the storage partition and on
update_chat_ctx, publishhistory(), the items the history shows. A regression test runs realtime turns on a stored session and checks that no reload carries the placeholder.Stacked on #8602.
Context for reviewing and coding agents