Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
…ewhere AgentServer(storage=None) always took a local SQLiteStorage, so the examples passed AgentDBStorage() and could not run on a self-hosted server, which has no agent-db. AgentServer._ensure_storage now picks, in one place, when the server runs: AgentDBStorage in the server's own project (its resolved URL and key pair, so options alone configure it) for a LiveKit Cloud URL, and SQLiteStorage on any other server or for a console call, which stays local whatever project LIVEKIT_URL names. The server logs the storage it uses at startup, and the voice examples no longer name one.
longcw
force-pushed
the
longc/auto-storage
branch
from
November 20, 2026 04:56
7da3386 to
0df5e4d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A server needs storage for its threads, and which one fits depends on where it runs: agent-db exists only on LiveKit Cloud, and a self-hosted server has none.
AgentServer(storage=None)always took a localSQLiteStorage, so the examples passedAgentDBStorage()and failed on a self-hosted server.AgentServer(storage=None)now picks the storage when the server runs:AgentDBStoragein the server's own project for a LiveKit Cloud URL, andSQLiteStorageon any other server or for a console call. An explicitstorage=is used as given, and the server logs the storage it uses at startup:Why the choice is made this way:
AgentServer._ensure_storageholds the whole rule. Doors bind the server's storage when it runs, not when they are added, so console can ask for its local choice before anything binds.LIVEKIT_URLnames.ws_url=,api_key=andapi_secret=works without the environment.The voice examples no longer name a storage, so they run on Cloud and on a self-hosted server as they are.
Stacked on #8602.
Context for reviewing and coding agents