Repository navigation
feat(murf): default TTS to Falcon 2.1 and Gordon voice - #8707
Open
gaurav-murf wants to merge 1 commit into
Open
gaurav-murf wants to merge 1 commit into
gaurav-murf wants to merge 1 commit into
Conversation
tinalenguyen
left a comment
Member
There was a problem hiding this comment.
hi, thanks for the PR! left a question about the default style
| TTSDefaultVoiceId = "en-US-matthew" | ||
| TTSDefaultVoiceStyle = "Conversation" | ||
| TTSDefaultVoiceId = "Gordon" | ||
| TTSDefaultVoiceStyle = "Conversational" |
Member
There was a problem hiding this comment.
since this default applies whenever style isn't passed, users with their own voice now get Conversational sent too, but some voices (e.g. Matthew) only list Conversation. does the API fall back for those, or could we only use the default style with the default voice?
Contributor
Author
There was a problem hiding this comment.
Murf TTS resolves unsupported styles to the closest matching style available for the selected voice. So Conversational should resolve to Conversation for voices like Matthew, and vice versa. This should not cause any issues with Matthew.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.