Repository navigation
Conversation
Contributor
Author
|
The PR-branch CLI against a local fake of the simulation API that returns sims-observability-notice.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lk agent simulatenow says when a run starts that the project's Agent Observability is off. Until now, users found out only at the end, when the run had no summary and the message called it "user data recording".Context: a new Simulations customer left Observability off because of that wording, then asked for metrics the dashboard already has (Slack: #sims feedback, Linear OCD-3768).
What changes
Turn on Agent Observability: <link>.::warning::annotation with the link at setup, so it shows in the GitHub run summary and isn't hidden in the collapsed Setup group. The end-of-run "no summary" line is now a::warning::too.How the CLI knows: the new
observability_disabledfield onSimulationRun.Create.Response, set by agent-service. The CLI doesn't parse error text, and it can't read project settings itself under API-key auth, which is the default.Blocked on livekit/protocol#2002 (new field) merging and a
github.com/livekit/protocolbump here. This branch doesn't compile against the currently pinned protocol. It was built and tested with a localreplacepointing at the protocol branch.go test ./cmd/lk/passes exceptTestDeployPrebuiltImageUnderUserAuth, which also fails on main on this machine (nodocker-credential-osxkeychain).Commits: a pure refactor (
createSimulationRunreturns the whole response), then the feature.Related: livekit/protocol#2002 (field), livekit/agents-private#1010 (sets the field), livekit/agents-private#1009 (rewrites the no-summary message).