Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go test ./cmd/lk/spent 19s of its 34s in four audio-modeSaytests. Each turn ends only after the agent has been quiet forturnSettle, which is 3s so that it outlasts a pause from a delegating model. The fake agent never pauses, but every test still waited the full 3s, and two of them also sleptturnSettle + 500ms.turnSettleis now asettlefield on the session, likereplyWait, and it still defaults to 3s, so the CLI behaves the same. The fake agent sets it to 100ms.TestAudioSayWaitsForHandoffIntroductionnever reachedawaitHandoffIntro. A handoff event doesn't count as the agent replying, so the turn was still waiting for a reply when the new agent's introduction arrived, and the test still passed with the handoff wait removed. The old agent now replies before the handoff, so only the handoff wait can keep the turn open for the introduction.cmd/lkpackage, test timeVerified:
go test ./cmd/lk/ -race -count=20 -run TestAudiopasses, with no data races.TestAudioSayWaitsForHandoffIntroductionnow fails (it passed on main). With a stale reply counted as the answer,TestAudioSayWaitsForTheAgentToHearTheUserstill fails.TestDeployPrebuiltImageUnderUserAuthfails locally on main too, becausedocker-credential-osxkeychainisn't installed. It's unrelated.