Repository navigation
fix(deps): update go deps #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/go-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Shell completion blocked by authentication
Without project credentials,
runBeforenow triggers project selection or authentication during shell completion. Flag candidates never reach Bash/Zsh when createRoomClient returns an error.Learn more
The upgraded urfave/cli completion branch calls
runBefore(ctx, commandChain(cmd))before invoking the completion handler; v3.9.0 returned completions without these hooks. The Bash completion function invokes the CLI with--generate-shell-completionand captures stdout. Forroom create, the registered hook calls createRoomClient, which resolves credentials through requireProjectForSDK and requireProjectWithOpts. With no credentials, selectProject prompts for authentication or returns an error in non-interactive mode, preventing the completion handler from running.Example: With no configured projects or
LIVEKIT_*credentials, runlk room create --generate-shell-completionwith non-terminal stdin. The new version returns a missing-project error instead of completion candidates; Bash/Zsh invoke this same completion path when Tab is pressed.Recommended fix: Bypass normal initialization and authentication hooks for shell-completion requests, or retain the previous dependency until that compatibility change is implemented. Cover a completion request with no configured credentials and assert that it emits candidates without prompts or authentication.
Was this helpful? React with 👍 or 👎 to provide feedback.