Skip to content

fix(migrate): pass StepContent transition props via slotProps - #863

Merged
ECWireless merged 1 commit into
mainfrom
fix/migrate-stepcontent-slotprops
Nov 16, 2026
Merged

ECWireless merged 1 commit into
mainfrom
fix/migrate-stepcontent-slotprops

Conversation

@ECWireless

Copy link
Copy Markdown
Collaborator

Description

The orchestrator and broadcaster migration pages pass MUI's deprecated TransitionProps to StepContent. MUI v9 removes that prop, which is why the Dependabot upgrade to @mui/material 9.5.0 (#857) fails typecheck.

This switches both pages to slotProps={{ transition: { unmountOnExit: false } }}, the form pages/migrate/delegator/index.tsx already uses. It works on the current MUI v7, so it can merge now. After that, @dependabot rebase on #857 should turn its CI green.

Type of Change

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation update
  • style: Code style/formatting changes (no logic changes)
  • refactor: Code refactoring (no behavior change)
  • perf: Performance improvement
  • test: Adding or updating tests
  • build: Build system or dependency changes
  • ci: CI/CD changes
  • chore: Other changes

Related Issue(s)

Related: #857

Changes Made

  • pages/migrate/orchestrator.tsx: StepContent uses slotProps.transition instead of TransitionProps
  • pages/migrate/broadcaster.tsx: same change

Testing

  • Tested locally
  • Added/updated tests
  • All tests passing

pnpm typecheck, pnpm lint, pnpm format:check and pnpm test (301 tests) pass on the current MUI v7. The same change was also checked against MUI 9.5.0 (the #857 branch): typecheck, tests and pnpm build pass.

Impact / Risk

Risk level: Low

Impacted areas: UI (the /migrate/orchestrator and /migrate/broadcaster steppers)

User impact: None. The same props reach the same Collapse transition.

Rollback plan: Revert this PR.

The orchestrator and broadcaster migration pages set StepContent's
deprecated TransitionProps, which MUI v9 removes. Use
slotProps.transition instead, as the delegator page already does. This
works on the current MUI v7 and unblocks the v9 upgrade (#857).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 04:52
@vercel

vercel Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
explorer-arbitrum-one Ready Ready Preview Nov 10, 2026 4:52am UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@ECWireless
ECWireless requested a review from Jipperism November 13, 2026 04:14
@ECWireless
ECWireless merged commit 34152ff into main Nov 16, 2026
9 checks passed
@ECWireless
ECWireless deleted the fix/migrate-stepcontent-slotprops branch November 16, 2026 22:47

This branch was successfully deployed

1 active deployment
Preview — 46e2dcae Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants