Repository navigation
fix(migrate): pass StepContent transition props via slotProps - #863
Merged
Merged
Conversation
The orchestrator and broadcaster migration pages set StepContent's deprecated TransitionProps, which MUI v9 removes. Use slotProps.transition instead, as the delegator page already does. This works on the current MUI v7 and unblocks the v9 upgrade (#857). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Jipperism
approved these changes
Nov 13, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The orchestrator and broadcaster migration pages pass MUI's deprecated
TransitionPropstoStepContent. MUI v9 removes that prop, which is why the Dependabot upgrade to@mui/material9.5.0 (#857) fails typecheck.This switches both pages to
slotProps={{ transition: { unmountOnExit: false } }}, the formpages/migrate/delegator/index.tsxalready uses. It works on the current MUI v7, so it can merge now. After that,@dependabot rebaseon #857 should turn its CI green.Type of Change
Related Issue(s)
Related: #857
Changes Made
pages/migrate/orchestrator.tsx:StepContentusesslotProps.transitioninstead ofTransitionPropspages/migrate/broadcaster.tsx: same changeTesting
pnpm typecheck,pnpm lint,pnpm format:checkandpnpm test(301 tests) pass on the current MUI v7. The same change was also checked against MUI 9.5.0 (the #857 branch): typecheck, tests andpnpm buildpass.Impact / Risk
Risk level: Low
Impacted areas: UI (the
/migrate/orchestratorand/migrate/broadcastersteppers)User impact: None. The same props reach the same Collapse transition.
Rollback plan: Revert this PR.