Repository navigation
Log orchestrator payment readiness rejections - #92
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The logger-enabled test omits recovery-reset and changed-rejection cases, leaving regressions that suppress later outage logs undetected.
1 open issue
What changed in this PR
Adds reason-specific logging for paid orchestrator /readyz rejections, making payment dependency failures easier to diagnose while preserving readiness decisions and HTTP responses.
Changes:
- Classifies chain, recipient, storage, worker, and price freshness failures.
- Logs rejection changes and resets duplicate suppression after recovery.
- Adds assertions for observer rejection reasons and repeated-log suppression.
| File | Description |
|---|---|
| orchestrator/metrics.go | Selects readiness rejection reasons and logs changes. |
| orchestrator/metrics_test.go | Checks repeated rejection-log suppression. |
| orchestrator/app.go | Passes the logger into paid readiness checks. |
| eth/payment_observer.go | Exposes specific chain and recipient rejection reasons. |
| eth/payment_observer_test.go | Verifies rejection reasons across observer states. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A short chain-readiness failure on the staging FFmpeg orchestrator caused its discovery response to lose all 17 app entries while the app health endpoint and heartbeats stayed healthy. The generic readiness failure made it difficult to tell which payment dependency rejected admission.
/readyzrejection when the reason changes. A successful check resets the suppression.Verified with
go test -race ./eth ./orchestrator ./internal/observability.