Repository navigation
Fix stale local images for moving tags like dev - #568
Merged
Merged
Conversation
anisaoshafi
added
semver: patch
docs: skip
anisaoshafi
marked this pull request as ready for review
October 29, 2026 17:09
joe4dev
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
lstk startskipped the pull for any tag exceptlatestwhen the image was already local.Tags like dev, stable or 2026.10 move to newer builds on Docker Hub, but once one was pulled, later starts kept reusing that local copy, so users stayed on an old build without knowing.
Solution
Reuse a local image only when it can't change upstream: a full version like
2026.10.4(optionally-bigdata,-amd64,-arm64) or a digest.Every other tag is pulled on start; if the pull fails (e.g. offline), the local image is still used.
The tag is read from the final image name, so
--imageworks the same way.dev,stable,2026.10, custom tags2026.10.4, digestlatestDocs
When lstk starts an emulator, a local image is reused only if its tag is a full version (e.g.
2026.10.4) or a digest. Any other tag is pulled first to get the newest build, falling back to the local image if the pull fails. Offline users should use a full version tag or a digest to avoid the pull attempt. The defaultconfig.tomlcomments describe this.Review
Human review advised: lstk now checks the registry on every start for tags that aren't a full version, which affects offline setups.
Resolves DEVX-1256