Repository navigation
Build with the Maven wrapper in IP Check and the Python tests - #1998
Merged
Merged
Conversation
The IP Check workflow, .utility/dash-summary.sh and the Python tests' maven_version.py called the runner's own mvn, while everything else uses ./mvnw (Maven 3.9.16). The GitHub runner image's newer Maven rejects docs/pom.xml, which declared maven-antrun-plugin twice: Maven 3.9 only warned and merged the two. So IP Check and Python Tests started failing on every pull request with "'build.plugins.plugin.(groupId:artifactId)' must be unique". - Use ./mvnw in all three, so CI no longer depends on whichever Maven the runner image ships. - Remove the first maven-antrun-plugin declaration in docs/pom.xml. Its only execution set a version_url property that nothing uses, so the docs build is unchanged. Co-authored-by: Rich Fecher <richard.fecher@vantor.com>
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IP Check (
dependencies) and Python Tests started failing on every pull request, including #1996 and #1997, with:Those two jobs called the runner's own
mvn: the IP Check workflow,.utility/dash-summary.sh, and the Python tests'maven_version.py. Everything else uses./mvnw(Maven 3.9.16). The GitHub runner image's newer Maven treats the duplicate plugin declaration indocs/pom.xmlas an error. Maven 3.9 only warned and merged the two declarations, which is why master's last runs on 2026-10-05 passed../mvnwin all three places, so CI doesn't depend on whichever Maven the runner image ships.maven-antrun-plugindeclaration indocs/pom.xml. Its only execution set aversion_urlproperty that nothing references, so the docs build does the same work.Verified locally:
./mvnw -pl docs generate-sourcesbuilds and still generatesindex.adoc../mvnw validateacross the reactor reports no duplicate-plugin warning.maven_version.get_maven_version()returns3.0.0.dev74.The same fix for
2.x-jdk8will follow in its own PR.