Skip to content

Build with the Maven wrapper in IP Check and the Python tests - #1998

Merged
rfecher merged 1 commit into
masterfrom
ci-maven-wrapper
Nov 2, 2026
Merged

rfecher merged 1 commit into
masterfrom
ci-maven-wrapper

Conversation

@rfecher

@rfecher rfecher commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

IP Check (dependencies) and Python Tests started failing on every pull request, including #1996 and #1997, with:

'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-antrun-plugin @ line 236
The project org.locationtech.geowave:geowave-doc:3.0.0-SNAPSHOT (docs/pom.xml) has 1 error

Those two jobs called the runner's own mvn: the IP Check workflow, .utility/dash-summary.sh, and the Python tests' maven_version.py. Everything else uses ./mvnw (Maven 3.9.16). The GitHub runner image's newer Maven treats the duplicate plugin declaration in docs/pom.xml as an error. Maven 3.9 only warned and merged the two declarations, which is why master's last runs on 2026-10-05 passed.

  • Use ./mvnw in all three places, so CI doesn't depend on whichever Maven the runner image ships.
  • Remove the first maven-antrun-plugin declaration in docs/pom.xml. Its only execution set a version_url property that nothing references, so the docs build does the same work.

Verified locally:

  • ./mvnw -pl docs generate-sources builds and still generates index.adoc.
  • ./mvnw validate across the reactor reports no duplicate-plugin warning.
  • maven_version.get_maven_version() returns 3.0.0.dev74.

The same fix for 2.x-jdk8 will follow in its own PR.

The IP Check workflow, .utility/dash-summary.sh and the Python tests'
maven_version.py called the runner's own mvn, while everything else uses
./mvnw (Maven 3.9.16). The GitHub runner image's newer Maven rejects
docs/pom.xml, which declared maven-antrun-plugin twice: Maven 3.9 only warned
and merged the two. So IP Check and Python Tests started failing on every pull
request with "'build.plugins.plugin.(groupId:artifactId)' must be unique".

- Use ./mvnw in all three, so CI no longer depends on whichever Maven the
  runner image ships.
- Remove the first maven-antrun-plugin declaration in docs/pom.xml. Its only
  execution set a version_url property that nothing uses, so the docs build is
  unchanged.

Co-authored-by: Rich Fecher <richard.fecher@vantor.com>
@rfecher rfecher added run-its Run the integration test matrix on this pull request and removed run-its Run the integration test matrix on this pull request labels Oct 26, 2026
@rfecher
rfecher merged commit 49fb8d2 into master Nov 2, 2026
18 of 20 checks passed
@rfecher
rfecher deleted the ci-maven-wrapper branch November 2, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant