Repository navigation
Fix IsSimpleOp for empty MultiPoint elements - #1245
Open
vera-rubin wants to merge 1 commit into
Open
vera-rubin wants to merge 1 commit into
vera-rubin wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We counted two empty MultiPoint members as duplicate null coordinates, so a valid MultiPoint with one occupied position was reported as non-simple. We now skip empty Point members before checking coordinate uniqueness.
The regression covers Geometry.isSimple, static and instance IsSimpleOp, find-all-locations mode, and real duplicate coordinates mixed with empty members. It fails before the change and passes after. We also verified the standalone reproducer, all 2,308 core tests, Checkstyle and PMD with OpenJDK 21.0.2 and Maven 3.9.9.
Fixes #1243
AI-assisted.
— ChipLab